[CHIA-3633] August 2025 pass of Ruff linting rules #19929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
There was a problem hiding this comment.
Pull Request Overview
This PR enables 6 new Ruff linting rules and removes one unused ignore rule to improve code quality. The changes focus on simplifying control flow by collapsing else-if statements and resolving variable shadowing issues.
- Converts nested
else-ifstatements toeliffor cleaner control flow - Fixes variable shadowing where loop variables or function parameters reused names in their scope
- Removes unnecessary type casting to
intwhere the operation already returns an integer
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/cpu_utilization.py | Adds noqa comment for loop variable modification |
| ruff.toml | Removes 6 ignored Ruff rules to enable new linting checks |
| chia/wallet/wallet_transaction_store.py | Simplifies nested else-if to elif |
| chia/wallet/wallet_state_manager.py | Fixes variable shadowing by renaming variables |
| chia/wallet/wallet_node.py | Converts multiple nested else-if statements to elif |
| chia/wallet/vc_wallet/vc_wallet.py | Simplifies nested conditional structure |
| chia/wallet/util/merkle_utils.py | Resolves variable shadowing in loop |
| chia/wallet/puzzle_drivers.py | Converts else-if to elif |
| chia/wallet/nft_wallet/nft_wallet.py | Fixes variable shadowing in loop |
| chia/wallet/cat_wallet/cat_outer_puzzle.py | Resolves variable shadowing |
| Multiple other files | Similar pattern of else-if to elif conversions and variable shadowing fixes |
altendky
suggested changes
Aug 8, 2025
altendky
previously approved these changes
Aug 11, 2025
altendky
approved these changes
Aug 11, 2025
emlowe
approved these changes
Aug 11, 2025
|
|
coverage exempted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a couple of months since the most recent rules were added to Ruff so I figured it's time to do another pass of some low-hanging fruit of rules to enable.
This PR enables 6 new rules and deletes one unused ignore. It's highly recommended to review the PR one commit at a time and for the
elifchange to hide whitespace.